Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resque activejob #1233

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

alexyakubenko
Copy link

@alexyakubenko alexyakubenko commented Feb 10, 2022

What does this pull request do?

Add recognition of resque jobs wrapped by ActiveJob

Why is it important?

All jobs are reported with the same ActiveJob::QueueAdapters::ResqueAdapter::JobWrapper name otherwise.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced

@apmmachine
Copy link
Collaborator

apmmachine commented Feb 10, 2022

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-31T05:45:19.763+0000

  • Duration: 3 min 18 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-agent-ruby.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/alexyakubenko return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/alexyakubenko : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/alexyakubenko : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jaggederest
Copy link
Contributor

Hi @alexyakubenko thank you for the contribution! Can you rebase on the latest main? I believe the CI is passing now so that may be helpful. I'll trigger CI once you update, or let me know. Once we've got CI passing I can get your PR reviewed and on schedule for merge.

@dmolinae
Copy link

@alexyakubenko @jaggederest Any updates on this? We are facing the same issue and applied a monkey patch for now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
APM-Agents (OLD)
  
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants