-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility for .trace_with
in graphql-ruby 2.3+
#1446
base: main
Are you sure you want to change the base?
Conversation
Hi @janko thanks for this contribution! As we would continue to support older versions of |
Yes, the old tracing API calls the |
Hey @janko I think some of the GraphQL tests are failing, would you mind taking a look? |
15c0967
to
a22fef6
Compare
I tried reproducing it locally, but unfortunately I cannot
I tried running FWIW, it seems the issue is only with combination of JRuby 9.2 and Rails 6.1. I don't know if it's deterministic (e.g. a JRuby bug with keyword arguments), or just some test-only race condition or something. |
a22fef6
to
799f681
Compare
What does this pull request do?
It adds support for
.trace_with
that was added in graphql-ruby as a more performant alternative to.tracer
. Instead of a single.trace
method that gets called on all types of events, with the new API the trace module implements a method for each event they want to trace.Why is it important?
The
.tracer
API has been deprecated and will be removed in graphql-ruby 3.0.Checklist
.rubocop.yml
)