Document.update() should accept fields set to None or empty #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
update-empty-field
branch
2 times, most recently
from
26401a9
to
ce95ec2
Compare
pquentin
reviewed
May 17, 2024
Comment on lines
523
to
530
| while True: | ||
| try: | ||
| r = await Tags.search().execute() | ||
| d = r.hits[0] | ||
| except IndexError: | ||
| continue | ||
| else: | ||
| break |
There was a problem hiding this comment.
What is this loop for? Do you need a refresh instead?
There was a problem hiding this comment.
Heh, I tried to find how other tests dealt with asynchronous updates and missed the refresh option. Yes, this would be handle much cleanly with a refresh, I'll update it.
miguelgrinberg
force-pushed
the
update-empty-field
branch
from
ce95ec2
to
26d54fe
Compare
pquentin
approved these changes
May 20, 2024
miguelgrinberg
added a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1819