-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zscaler_zia: Fix improper escaping of backslash characters #9842
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @kcreddy |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that this is fixing a customer issue, but it troubles me that we are going out of our way to transform invalid JSON into valid JSON in one location at the possible cost of transforming other valid JSON into syntactically correct, but semantically incorrect JSON at many other sites (any \x
escape sequence anywhere else in the input will be converted to a litteral "\x" string). Why are we not asking the sender of the invalid message to fix their encoding?
@efd6 That does make sense especially when the ZIA documentation mentions how to overcome this issue with a configuration change. Moving the PR to draft. I will close it once the user is satisfied with the solution to change the configuration instead. |
Proposed commit message
See title
Checklist
changelog.yml
file.How to test this PR locally
elastic-package stack down && elastic-package build && elastic-package stack up -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v
Screenshots