Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add the subobjects adoption guide to docs #9874

Merged
merged 5 commits into from
May 27, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented May 15, 2024

Proposed commit message

Add history, usage, and recommendations for using the subobjects mapping parameter in Elasticsearch and in integrations.

Checklist

@zmoog zmoog added Team:Cloud-Monitoring Label for the Cloud Monitoring team docs labels May 15, 2024
@zmoog zmoog self-assigned this May 15, 2024
@zmoog zmoog marked this pull request as ready for review May 15, 2024 11:44
@zmoog zmoog requested a review from a team as a code owner May 15, 2024 11:44
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Added some small suggestions.

docs/subobjects_adoption_guide.md Outdated Show resolved Hide resolved
docs/subobjects_adoption_guide.md Outdated Show resolved Hide resolved
docs/subobjects_adoption_guide.md Outdated Show resolved Hide resolved

#### Field vs. Data Stream

Users can set the subobjects mapping parameter on a single field or for the whole data stream (root level).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we give any recommendation about when to use one or the other option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, adding a couple of paragraphs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsoriano, I moved this section to the following overview; it seems to make more sense. I also added a couple of paragraphs that mention cases for field and data stream levels.

Let me know what you think.

docs/subobjects_adoption_guide.md Show resolved Hide resolved
@elasticmachine
Copy link

elasticmachine commented May 15, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@zmoog zmoog enabled auto-merge (squash) May 24, 2024 14:07
@zmoog zmoog force-pushed the zmoog/subobjects-adoption-guide branch from 1c5e346 to 04c8c21 Compare May 24, 2024 14:14
@zmoog
Copy link
Contributor Author

zmoog commented May 24, 2024

/test

1 similar comment
@zmoog
Copy link
Contributor Author

zmoog commented May 24, 2024

/test

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

/test

@zmoog zmoog force-pushed the zmoog/subobjects-adoption-guide branch from 04c8c21 to 3f90caa Compare May 27, 2024 05:27
@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

/test

2 similar comments
@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

/test

@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

/test

@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

A few integrations keep failing due to the following error:

Error: error running package system tests: could not complete test run: could not setup service: Terraform deployer is unhealthy: container (ID: ffae3c688cb20f68b9e2ba593564c7c9b6987918a725a8fed063bee2242ee35a) exited with code 1

@zmoog
Copy link
Contributor Author

zmoog commented May 27, 2024

/test

@zmoog zmoog force-pushed the zmoog/subobjects-adoption-guide branch from 3f90caa to a1432ea Compare May 27, 2024 16:17
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

@zmoog zmoog merged commit fdb2eb2 into elastic:main May 27, 2024
3 checks passed
@zmoog zmoog deleted the zmoog/subobjects-adoption-guide branch May 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants