-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add the subobjects adoption guide to docs #9874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Added some small suggestions.
docs/subobjects_adoption_guide.md
Outdated
|
||
#### Field vs. Data Stream | ||
|
||
Users can set the subobjects mapping parameter on a single field or for the whole data stream (root level). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we give any recommendation about when to use one or the other option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, adding a couple of paragraphs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsoriano, I moved this section to the following overview; it seems to make more sense. I also added a couple of paragraphs that mention cases for field and data stream levels.
Let me know what you think.
🚀 Benchmarks reportTo see the full report comment with |
1c5e346
to
04c8c21
Compare
/test |
1 similar comment
/test |
Quality Gate passedIssues Measures |
/test |
04c8c21
to
3f90caa
Compare
/test |
2 similar comments
/test |
/test |
A few integrations keep failing due to the following error:
|
/test |
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
3f90caa
to
a1432ea
Compare
💚 Build Succeeded
History
cc @zmoog |
Proposed commit message
Add history, usage, and recommendations for using the subobjects mapping parameter in Elasticsearch and in integrations.
Checklist
I have reviewed [tips for building integrations](https://github.com/elastic/integrations/blob/main/docs/tips_for_building_integrations.md) and this pull request is aligned with them.I have verified that all data streams collect metrics or logs.I have added an entry to my package'schangelog.yml
file.I have verified that Kibana version constraints are current according to guidelines.