Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fortinet_fortigate] Tolerate space between syslog priority and message #9898

Merged
merged 3 commits into from
May 17, 2024
Merged

[fortinet_fortigate] Tolerate space between syslog priority and message #9898

merged 3 commits into from
May 17, 2024
+97 −4

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 16, 2024 •
edited

Proposed commit message

  • Logs sent from Fortinet Analyzer may include a space between the syslog priority and start of the message. This change add support for this whitespace.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/fortinet_fortigate
elastic-package test

Related issues

@taylor-swanson
[fortinet_fortigate] Tolerate space between syslog priority and message
b8c39c5 
- Logs sent from Fortinet Analyzer may include a space between the
syslog priority and start of the message. This change add support
for this whitespace.
@taylor-swanson taylor-swanson added bug Something isn't working Integration:Fortinet_FortiGate Team:Security-Deployment and Devices Deployment and Devices Security team labels May 16, 2024
@taylor-swanson taylor-swanson self-assigned this May 16, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson marked this pull request as ready for review May 17, 2024 13:45
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 17, 2024 13:45
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@taylor-swanson taylor-swanson merged commit f4c694a into elastic:main May 17, 2024
5 checks passed
@elasticmachine
Copy link

Package fortinet_fortigate - 1.25.3 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working Integration:Fortinet_FortiGate Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Update Fortinet Firewall pipeline.yml to include space
3 participants
@taylor-swanson @elasticmachine @pkoutsovasilis