Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ios] fix timestamp with zones parsing #9900

Merged
merged 4 commits into from
May 17, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis commented May 16, 2024

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test pipeline -v

Related issues

Screenshots

image

Kibana displays the timestamp in the timezone of the client
image

@pkoutsovasilis pkoutsovasilis added bug Something isn't working Integration:CiscoIOS Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team labels May 16, 2024
@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/fix_cisco_ios_tz_pt2 branch from fea22da to 94d63a8 Compare May 16, 2024 15:27
@pkoutsovasilis
Copy link
Contributor Author

@taylor-swanson can you have a look at it? It is peculiar but I think it gets the job with the timestamps and zone done

@elasticmachine
Copy link

elasticmachine commented May 16, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/fix_cisco_ios_tz_pt2 branch from 7f26adc to 00c8a0f Compare May 17, 2024 07:15
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review May 17, 2024 08:02
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner May 17, 2024 08:02
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@pkoutsovasilis pkoutsovasilis self-assigned this May 17, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @pkoutsovasilis

@pkoutsovasilis pkoutsovasilis merged commit e5055b2 into main May 17, 2024
5 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/fix_cisco_ios_tz_pt2 branch May 17, 2024 15:59
@elasticmachine
Copy link

Package cisco_ios - 1.26.8 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:CiscoIOS Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants