Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Integration] GitLab #9903

Closed
wants to merge 7 commits into from
Closed

[New Integration] GitLab #9903

wants to merge 7 commits into from

Conversation

tehbooom
Copy link
Member

  • Enhancement

Proposed commit message

New integration for GitLab

Some examples logs were pulled from the documentation

The other logs were pulled from a test GitLab instance using the free tier.

Not all logs from GitLab are collected since we need a dev license and more example logs.

The following logs will need to be ingested from another integration:

  • nginx
  • postgresql
  • redis
  • prometheus
  • mattermost

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Alphayeeeet
Copy link
Contributor

@tehbooom Thanks for looking into this topic. Is it possible to use use the mentioned other integrations inside the Gitlab integration as a one for all solution?

I hope it's understandable what I mean. So that I don't need an integration policy for each of the components as the GitLab integration should manage all that (preferably configurable in the policy settings).

@tehbooom
Copy link
Member Author

The following logs will need to be ingested from another integration:

  • nginx
  • postgresql
  • redis
  • prometheus
  • mattermost

Hey @Alphayeeeet , there have been discussions around using one ingest pipeline for two integrations however at this time it is not supported. Ive decided to not recreate the pipelines in this integration incase we do in the future move towards utilizing more than one integration pipeline for a single integration. As of now, you will need to add more integrations to the policy to fully monitor all of GitLab.

@tehbooom tehbooom added New Integration Team:Security-Service Integrations Security Service Integrations Team labels May 17, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
73.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6
Copy link
Contributor

efd6 commented May 19, 2024

Two comments on this.

  1. There is a GitLab CE PR open at the moment. It may be good to think about whether it's possible to simplify the surface for integration users in some way.
  2. The size of this PR is too large to reasonably review with any real quality control. It would be good to reduce the chunk size of review objects. I suggest prioritising the data streams and making a series of PR that add them in priority order.

@tehbooom
Copy link
Member Author

Closing since it is a duplicate of #9747. After it is merge will start to add more datastreams for this PR.

@tehbooom tehbooom closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants