fix: [Obs Alerts > Alert Detail][KEYBOARD]: Table header has tooltips that must be keyboard focusable #183523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that must be keyboard focusable Close: elastic/observability-dev#3379
alexwizp
changed the title
|
/ci |
alexwizp
added
release_note:skip
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
|
Pinging @elastic/unified-observability (Team:Observability) |
walterra
reviewed
May 16, 2024
There was a problem hiding this comment.
Thanks for picking this up! There is a variant of this table that follows the same pattern, would be great if you can update that one too. It's log_rate_analysis_results_table_groups.tsx in the same folder. That table will render when "Smart grouping" is enabled:
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-dev/issues/3379
Description
The Obs Alert Detail view has a table with several tooltips that are not keyboard focusable. Screenshot attached below.
Steps to recreate
[ ... ]menu and then click "Run rule"Alertsview and click on the[ ... ]menu in the data grid, then click on "View alert details"What was changed?:
Screen
Screen.Recording.2024-05-15.at.17.09.29.mov