Log uncaughtExceptions in our logging system
#183530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
afharo
commented
May 15, 2024
|
|
||
| expect(logger.get('process').warn).toHaveBeenCalledTimes(1); | ||
| expect(logger.get('environment').warn).toHaveBeenCalledTimes(1); |
There was a problem hiding this comment.
Weird that the test works with both words 🤷
| await service.preboot({ analytics }); | ||
|
|
||
| const err = new Error('something went wrong'); | ||
| process.emit('unhandledRejection', err, new Promise((res, rej) => rej(err))); | ||
| process.emit('unhandledRejection', err, new Promise((res, rej) => {})); |
There was a problem hiding this comment.
The problem was not the process.emit, was the actual Promise rejecting 😅
| @@ -68,6 +68,14 @@ export class EnvironmentService { | |||
| const message = (reason as Error)?.stack ?? JSON.stringify(reason); | |||
| this.log.warn(`Detected an unhandled Promise rejection: ${message}`); | |||
| }); | |||
| // Log uncaughtExceptions in our logger before crashing the process: https://github.com/elastic/kibana/issues/183182 | |||
| process.on('uncaughtExceptionMonitor', (error, origin) => { | |||
There was a problem hiding this comment.
Using uncaughtExceptionMonitor instead of uncaughtException because, according to the docs, the only difference is that the latter intercepts the exit call.
|
/ci |
|
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
pgayvallet
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #183182
Checklist
Risk Matrix
unhandledRejections (refer to theoriginparameter).For maintainers