[Security Solution][Endpoint] Improve Axios error output for dev scripts + change default for creation of Kbn/ES clients to NOT include self-signed certs #183531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
release_note:skip
|
/ci |
|
/ci |
|
/ci |
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
szwarckonrad
approved these changes
May 17, 2024
parkiino
approved these changes
May 20, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors included in this PR include:
.catch()to calls made with Axios and wraps errors with more information about the failed requestnoCertForSsloptions of kibana scripting services to:useCertForSslfalse: by default the factory functions will NOT inject the serf-signed cert into the clientshttps. That intern cause all of our CLI scripts to not be usable against cloud instances (for testing). This change reverts that but still enables one to include it by setting the (renamed) optionuseCertForSslwhen creating a ES or KBN client.