[ML] Single Metric Viewer embeddable: ensure creating job rule from anomaly click actions is successful #183554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing rules from any page
alvarezmelissa87
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
walterra
approved these changes
May 16, 2024
peteharverson
approved these changes
May 16, 2024
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #183451
This PR updates the utils functions used by the rule editor flyout to create/update/delete job rules. The functions now accept the services they require in the case that they are not available.
This takes a step in the direction of removing dependency on the dependency cache. This needs to be backported to 8.14 so trying to keep code churn as small as possible. A next step will be to convert this utils file to ts and wrap it up as a factory service as we've done with other services that had dependency cache dependencies.