Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] minor typing improvement #183572

Merged
merged 1 commit into from
May 17, 2024
Merged

[ES|QL] minor typing improvement #183572

merged 1 commit into from
May 17, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented May 15, 2024 •
edited

Summary

I can never remember where these callbacks are and before, VSCode couldn't find them via a type search. All better now:

Screenshot 2024-05-16 at 8 28 33 AM

@drewdaemon
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review May 16, 2024 14:29
@drewdaemon drewdaemon requested a review from a team as a code owner May 16, 2024 14:29
@drewdaemon drewdaemon added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL Team:ESQL ES|QL related features in Kibana labels May 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon drewdaemon merged commit 0d79f90 into elastic:main May 17, 2024
28 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drewdaemon @kibana-ci @elasticmachine @stratoula @kibanamachine