[Security AI Assistant] Fixed assistant availability check in the overlay #183585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
approved these changes
May 16, 2024
YulNaumenko
added
v8.14.0
release_note:skip
PhilippeOberti
approved these changes
May 16, 2024
stephmilovic
approved these changes
May 16, 2024
|
Looks like the
|
spong
approved these changes
May 16, 2024
There was a problem hiding this comment.
Checked out, tested locally, and code reviewed -- LGTM! Thanks for the speedy fix here @YulNaumenko! 🙏
maximpn
approved these changes
May 17, 2024
banderror
reviewed
May 17, 2024
| @@ -105,6 +105,7 @@ export const RulesTableToolbar = React.memo(() => { | |||
| getPromptContext={getPromptContext} | |||
| suggestedUserPrompt={i18nAssistant.EXPLAIN_THEN_SUMMARIZE_RULE_DETAILS} | |||
| tooltip={i18nAssistant.RULE_MANAGEMENT_CONTEXT_TOOLTIP} | |||
| isAssistantEnabled={isAssistantEnabled} | |||
There was a problem hiding this comment.
Can we call const { hasAssistantPrivilege, isAssistantEnabled } = useAssistantAvailability(); inside the NewChat component? Why our code needs to be changed every time some internal logic of the Assistant changes?
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
YulNaumenko
added
v8.14.0
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
spong
pushed a commit
to spong/kibana
that referenced
this pull request
May 17, 2024
…rlay (elastic#183585) This PR adding the check for the assistant license. The initial bug before fix: https://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a after: no error dialog pop up (cherry picked from commit e24502d)
spong
added a commit
that referenced
this pull request
May 17, 2024
…the overlay (#183585) (#183784) # Backport This will backport the following commits from `main` to `8.14`: - [[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)](#183585) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yuliia Naumenko","email":"jo.naumenko@gmail.com"},"sourceCommit":{"committedDate":"2024-05-17T18:00:46Z","message":"[Security AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","backport:skip","v8.15.0"],"number":183585,"url":"#183585 AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183585 AI Assistant] Fixed assistant availability check in the overlay (#183585)\n\nThis PR adding the check for the assistant license.\r\n\r\nThe initial bug before fix:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/55110838/1afcb112-714a-43e1-8f0d-58fb5b37fc4a\r\n\r\nafter:\r\nno error dialog pop up","sha":"e24502d70ab98e738552ec46e69707d83152cf44"}}]}] BACKPORT--> Co-authored-by: Yuliia Naumenko <jo.naumenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adding the check for the assistant license.
The initial bug before fix:
errrrec.mov
after:
no error dialog pop up