fix: don't destroy BrowserView webContents on owner window close

[codebytere]

Description of Change

Closes #42033.
Refs #35658

The above PR made it such that we explicitly destroyed the webContents in all BrowserViews currently attached to a give BrowserWindow when the BrowserWindow closed, which was a breaking change from previous BrowserView behavior. We should preserve the previous behavior.

cc @nornagon in case this was for a specific reason i'm not aware of!

Checklist

• PR description included and stakeholders cc'd
• npm test passes
• tests are changed or added
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where BrowserView webContents were destroyed on owner BrowserWindow closure.

[codebytere]

Looks like this affects:

webContents module will-prevent-unload event emits if beforeunload returns false in a BrowserView

seems like this answers my question for impetus of the original change - will investigate alternatives 🤔

[yangannyx]

@codebytere Felix and I took a look at this on Friday and came up with the approach of moving the webContents forEach loop from the browserWindow 'close' event to the 'closed' event. This works when testing with the fiddle attached in #42033, and was in the process of writing tests when I saw this PR.

What do you think abt this approach?

[felixrieseberg]

@codebytere Thank you! For what it's worth, a lot of the behavior here is undocumented anyway (see also #28382 😉) so I think we kind of get to solve the problem however we feel like it

[codebytere]

@yangannyx i like that approach! let's go with that - I'll close this out. Let me know when you'd like some review on. PR and i'll take a look 😁

[codebytere]

@yangannyx is this still something you're planning to pursue? Given it's a stable blocker, happy to help if necessary!

[yangannyx]

@codebytere I ended up scrapping the approach of using closed instead of close because it seemed to also not support this behavior. I haven't worked on it since. Still happy to open a PR to confirm this from CI

webContents module will-prevent-unload event emits if beforeunload returns false in a BrowserView

[yangannyx]

Just put up the PR. It looks like the webContents module will-prevent-unload event emits if beforeunload returns false in a BrowserView test passes woo!