Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix GPU temperature conversion in the popup chart #1917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxd
Copy link

@maxd maxd commented Apr 29, 2024

This PR fixes GPU temperature conversion in the popup chart after an incorrect fix in the fb63ece commit related to the #1809 issue.

Before this fix the GPU chart show incorrect temperature value:

Screenshot 2024-04-29 at 20 43 19 Screenshot 2024-04-29 at 20 43 44

As you can see it shows 0C instead of 48C and 3300F instead of 118F.

After this fix it should show the correct values:

Screenshot 2024-04-29 at 20 41 19 Screenshot 2024-04-29 at 20 41 53

@exelban
Copy link
Owner

exelban commented May 2, 2024

hi. Please use temperature function to convert the temperature.

@BenTalagan
Copy link

Hi, any update on this PR ? It adresses an annoying bug, and it'd be awesome to get it finalized ! Thx for the hard work.

…rect fix in the fb63ece commit related to the 1809 issue
@maxd maxd force-pushed the issue-1809-fix-temperature-conversion branch from 106beb8 to c90fac8 Compare May 28, 2024 19:02
@maxd
Copy link
Author

maxd commented May 28, 2024

@exelban The temperature function is responsible for converting and formatting. I can't use it here because I only need the converting part. I suppose there are no ways to solve described problem without splitting this function into two.

So, I decided to update my PR and refactor this function. Now, the temperature function will be responsible for converting to a selected temperature unit, and the format extension function will be responsible for formatting.

Is this an acceptable solution, or can you provide a better one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants