New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): improve tests and instructions for Expense Tracker project #54624
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed till step 20.
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65822bd82d708c4895080c35.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the project.
Provided that match/ case
have not been introduced in the curriculum, I think this project can incorporate that in place if if..elif
statements used to create the menu.
@ilenia-magoni, @fhsinchy, @Dario-DC What do you think?
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65823ff0d4b991510fade1a8.md
Show resolved
Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65824dfdb6815d563b2d3256.md
Outdated
Show resolved
Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65826af5b226a5628aa154b1.md
Show resolved
Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65823634a308cb4d6bcc5fa6.md
Outdated
Show resolved
Hide resolved
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65824561f3478e5371a33ae5.md
Show resolved
Hide resolved
Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>
This is the first time that |
...ith-python/learn-lambda-functions-by-building-an-expense-tracker/65822bd82d708c4895080c35.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything good, other than: I have doubts on the last step. We never introduce how to work with multiple fails, so it's kind of suddend and a bit of a whiplash to have if __name__
. I would totally want to have it taught, but I would see it in a proper multifile project.
I'm okay with removing that step from this project. The password generator is the the first project in which we import something, and probably it makes sense to not use What do you think? @ilenia-magoni @zairahira @fhsinchy @larymak @ihechikara |
To maintain clarity and ensure a smooth learning curve, I'm in favor of removing the |
My proposal is to remove it from the expense tracker and the case converter. And keep it in the password generator, since we talk about importing modules in that project. If we remove it, we should simply delete the step in which we create |
Checklist:
main
branch of freeCodeCamp.Closes #52722
Closes #53135
Closes #53463
Closes #52580