Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added a Hint to JavaScript Challenges #54630

Closed
wants to merge 1 commit into from

Conversation

RugvedKute
Copy link

Fixed the missing hint for the this keyword in the JavaScript challenges. The hint has been added to the Learn Basic OOP by Building a Shopping Cart lesson.

Checklist:

Closes #54602
Screenshot 2024-05-03 at 4 22 34 AM

…5-javascript-algorithms-and-data-structures-22/learn-basic-oop-by-building-a-shopping-cart/63f03686c5ea863533ec71f4.md
@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 2, 2024
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RugvedKute, thank you for the PR.

We have reviewed the changes and decided to go with #54653 instead. As such, we are going to close this PR.

If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.

Thanks again 🙂


If you have any questions, feel free to ask questions on the "Contributors" category on our forum or the contributors chat room.

@@ -11,14 +11,14 @@ Declare a variable `tax` and assign it the value of calling your new `.calculate

# --hints--

Use `const` to declare a variable named `tax`.
Use `const` to declare a variable named `tax`. Remember to use the `this` keyword.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in #54602 (comment), we would like to add the note to the last hint instead of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hint to remember this keyword for step 48 of shopping cart project
2 participants