Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert progressbar test to Playwright #54636

Merged
merged 3 commits into from May 7, 2024
Merged

feat: convert progressbar test to Playwright #54636

merged 3 commits into from May 7, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented May 3, 2024 •
edited

Checklist:

Closes #XXXXX

@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label May 3, 2024
@Sembauke Sembauke marked this pull request as ready for review May 3, 2024 09:42
@Sembauke Sembauke requested a review from a team as a code owner May 3, 2024 09:42
@Sembauke Sembauke closed this May 3, 2024
@Sembauke Sembauke reopened this May 3, 2024
naomi-lgbt
naomi-lgbt requested changes May 3, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More logical test name?

e2e/progress-bar.spec.ts Outdated Show resolved Hide resolved
Sembauke and others added 2 commits May 4, 2024 09:30
@Sembauke
Update e2e/progress-bar.spec.ts
a92d873 
Co-authored-by: Naomi <nhcarrigan@gmail.com>
@Sembauke
fix: lint
6e74dfc
@Sembauke Sembauke requested a review from naomi-lgbt May 6, 2024 09:09
@Sembauke Sembauke mentioned this pull request May 7, 2024
Open
61 tasks
@huyenltnguyen huyenltnguyen merged commit c3b5c11 into freeCodeCamp:main May 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sembauke @huyenltnguyen @naomi-lgbt