fix(curriculum): update test todo app step 6 #54650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
scope: curriculum
jdwilkin4
approved these changes
May 6, 2024
jdwilkin4
added
status: waiting review
jdwilkin4
reviewed
May 7, 2024
| @@ -40,7 +40,7 @@ assert.match(code, /openTaskFormBtn\.addEventListener\(\s*('|"|`)click\1/) | |||
| Your event listener's callback function should use the `classList.toggle()` method to toggle the `hidden` class on the `taskForm` element. Refer back to the example provided in the description. | |||
|
|
|||
| ```js | |||
| assert.match(code, /openTaskFormBtn\.addEventListener\(\s*('|"|`)click\1\s*,\s*(?:\(\s*\)\s*=>\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\2\s*\)\s*\)|\s*function\s*\(\s*\)\s*\s*{\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\3\s*\)\s*}\s*\)\s*;)/) | |||
| assert.match(code, /openTaskFormBtn\.addEventListener\(\s*('|"|`)click\1\s*,\s*(?:\(\s*\)\s*=>\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\2\s*\)\s*\)|\s*function\s*\(\s*\)\s*\s*{\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\3\s*\)\s*}\s*\)\s*;|\s*\(\s*\)\s*=\s*>\s*\{\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\4\s*\)\s*\}\s*\)\s*;)/) | |||
There was a problem hiding this comment.
Let's actually remove the regex altogether and simulate the click event instead.
something like this should work.
I suggest testing it on your end too but this should be easier to manage
Suggested change
| assert.match(code, /openTaskFormBtn\.addEventListener\(\s*('|"|`)click\1\s*,\s*(?:\(\s*\)\s*=>\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\2\s*\)\s*\)|\s*function\s*\(\s*\)\s*\s*{\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\3\s*\)\s*}\s*\)\s*;|\s*\(\s*\)\s*=\s*>\s*\{\s*taskForm\s*\.classList\s*\.\s*toggle\s*\(\s*('|"|`)hidden\4\s*\)\s*\}\s*\)\s*;)/) | |
| assert(taskForm.classList.contains('hidden')); | |
| openTaskFormBtn.click(); | |
| assert(!taskForm.classList.contains('hidden')); |
jdwilkin4
added
status: waiting update
|
It looks like another PR was merged in that address this issue. So as result, we are going to close yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #54625
Pass for arrow function syntax, without curly braces
Pass for arrow function syntax, with curly braces
Pass for regular function
