Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Calculate ParticleRenderer BoundingBox #1963

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Feat: Calculate ParticleRenderer BoundingBox #1963

wants to merge 50 commits into from

Conversation

JujieX
Copy link
Contributor

@JujieX JujieX commented Jan 11, 2024 •
edited

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Calculate ParticleRenderer BoundingBox

@JujieX JujieX added this to the 1.2 milestone Jan 11, 2024
@JujieX JujieX self-assigned this Jan 11, 2024
@cptbtptpbcptdtptp
Copy link
Collaborator

According to the subsequent design of localbounds, this should be better:

image

@JujieX
Copy link
Contributor Author

JujieX commented Jan 15, 2024

According to the subsequent design of localbounds, this should be better:

image

Currently the result is the local bounds of the renderer.
Each calculation part is correspond to its GPU equivalent on a one-to-one basis.
image

GuoLei1990
GuoLei1990 requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit tets

@GuoLei1990 GuoLei1990 added the enhancement New feature or request label Jan 22, 2024
GuoLei1990
GuoLei1990 reviewed Jan 23, 2024
View reviewed changes
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
GuoLei1990
GuoLei1990 reviewed May 14, 2024
View reviewed changes
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleRenderer.ts Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleRenderer.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleGenerator.ts Outdated Show resolved Hide resolved
packages/core/src/particle/ParticleRenderer.ts Outdated Show resolved Hide resolved
packages/core/src/particle/modules/ParticleCompositeCurve.ts Show resolved Hide resolved
packages/core/src/particle/modules/ParticleCompositeCurve.ts Show resolved Hide resolved
GuoLei1990
GuoLei1990 reviewed May 31, 2024
View reviewed changes
packages/core/src/particle/ParticleGenerator.ts
/**
* @internal
*/
_resizeBoundsArray(isIncrease: boolean): void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause the life of particles to be nonlinear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 requested changes

@cptbtptpbcptdtptp cptbtptpbcptdtptp Awaiting requested review from cptbtptpbcptdtptp

Requested changes must be addressed to merge this pull request.

Assignees

@JujieX JujieX

Labels
enhancement New feature or request particle
Projects
Milestone 1.3 iteration plan
Status: No status
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JujieX @cptbtptpbcptdtptp @GuoLei1990