Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logic problem of onPointerUp and onPointerClick #2042

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Mar 18, 2024

  • Click
    step 1. pointerDown hits the collider
    step 2. pointerMove outside the collider
    step 3. pointerUp hits the collider

  • Up
    step 1. pointerDown outside the collider
    step 2. pointerUp hits the collider

@cptbtptpbcptdtptp cptbtptpbcptdtptp added bug Something isn't working Input Input related functions labels Mar 18, 2024
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 1.2 milestone Mar 18, 2024
@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.07%. Comparing base (025033e) to head (f86007e).
Report is 173 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   67.46%   66.07%   -1.39%     
==========================================
  Files         471      460      -11     
  Lines       23809    22996     -813     
  Branches     3402     3369      -33     
==========================================
- Hits        16062    15194     -868     
- Misses       6556     6643      +87     
+ Partials     1191     1159      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazylxr crazylxr modified the milestones: 1.2, 1.3 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Input Input related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants