Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transparent shadow #2080

Open
wants to merge 8 commits into
base: dev/1.3
Choose a base branch
from

Conversation

zhuxudong
Copy link
Member

@zhuxudong zhuxudong commented Apr 17, 2024

Please check if the PR fulfills these requirements

RFC: https://yuque.antfin-inc.com/shensi.zxd/ftoum6/msk7bmlizt1zlp1h
Playground: galacean/galacean.github.io#1011
dither algorithm compare:https://bartwronski.com/2016/10/30/dithering-part-three-real-world-2d-quantization-dithering/

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@zhuxudong zhuxudong added bug Something isn't working rendering Rendering related functions shadow labels Apr 17, 2024
@zhuxudong zhuxudong added this to the 1.3 milestone Apr 17, 2024
@zhuxudong zhuxudong self-assigned this Apr 17, 2024
@zhuxudong zhuxudong linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Please upload report for BASE (dev/1.3@f465149). Learn more about missing BASE report.

Current head ba15e9b differs from pull request most recent head 5e2e37a

Please upload reports for the commit 5e2e37a to get more accurate results.

Files Patch % Lines
packages/core/src/Scene.ts 14.28% 6 Missing ⚠️
...ckages/core/src/shadow/CascadedShadowCasterPass.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev/1.3    #2080   +/-   ##
==========================================
  Coverage           ?   66.06%           
==========================================
  Files              ?      460           
  Lines              ?    23032           
  Branches           ?     3376           
==========================================
  Hits               ?    15216           
  Misses             ?     6651           
  Partials           ?     1165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rendering Rendering related functions shadow
Projects
Development

Successfully merging this pull request may close these issues.

Shadow support cutoff mode
1 participant