Changes 4: Refactor PlainTextContentStorageHandler to use Language object #6448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Refactoring
Language::single()
method to create a Language placeholder object in single language installationsContentStorageHandler
andPlainTextContentStorageHandler
methodsContentStorage
to always provide a full language object to the storage methods. This is only temporary to keep all the unit tests working.ContentStorage
will be removed later, as planned.Outlook
PlainTextContentStorageHandler
class will no longer implement the interface but extend the abstractContentStorageHandler
class. This change will also remove the__construct
method, which will then be implemented by the abstract. Changes 5: ContentStorageHandler Abstract #6449::write
method will later be moved to theContentStorageHandler
class as an abstract method.ContentStorageHandler
will then also get a non-abstract update and create method, which will use the new write method by default. This will add the option for storage handlers to only modify the write method if no further logic is needed for create and update. Changes 10: New MemoryContentStorageHandler #6457Breaking changes
None
Ready?
For review team