updated sqlalchemy to 1.4 using a up-to-date query syntax

getredash · Dec 22, 2023 · 3b9234b · 3b9234b
1 parent 30b59eb
commit 3b9234b
Show file tree

Hide file tree

Showing 103 changed files with 2,346 additions and 1,348 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -39,11 +39,11 @@ jobs:
           docker compose up -d
           sleep 10
       - name: Create Test Database
-        run: docker compose -p redash run --rm postgres psql -h postgres -U postgres -c "create database tests;"
+        run: docker compose run --rm postgres psql -h postgres -U postgres -c "create database tests;"
       - name: List Enabled Query Runners
-        run: docker compose -p redash run --rm redash manage ds list_types
+        run: docker compose run --rm redash manage ds list_types
       - name: Run Tests
-        run: docker compose -p redash run --name tests redash tests --junitxml=junit.xml --cov-report=xml --cov=redash --cov-config=.coveragerc tests/
+        run: docker compose run --name tests redash tests --junitxml=junit.xml --cov-report=xml --cov=redash --cov-config=.coveragerc tests/
       - name: Copy Test Results
         run: |
           mkdir -p /tmp/test-results/unit-tests
@@ -137,6 +137,7 @@ jobs:
           set -x
           yarn cypress build
           yarn cypress start -- --skip-db-seed
+          docker compose run server create_db
           docker compose run cypress yarn cypress db-seed
       - name: Execute Cypress Tests
         run: yarn cypress run-ci

diff --git a/client/app/components/items-list/classes/ItemsFetcher.js b/client/app/components/items-list/classes/ItemsFetcher.js
@@ -74,7 +74,7 @@ export class PaginatedListFetcher extends ItemsFetcher {
     return this._originalGetRequest(
       {
         page: paginator.page,
-        page_size: paginator.itemsPerPage,
+        per_page: paginator.itemsPerPage,
         order: sorter.compiled,
         q: isString(searchTerm) && searchTerm !== "" ? searchTerm : undefined,
         tags: selectedTags,

diff --git a/client/app/components/items-list/classes/ItemsSource.d.ts b/client/app/components/items-list/classes/ItemsSource.d.ts
@@ -18,7 +18,7 @@ export type GetResourceRequest = any; // TODO: Add stricter type
 export interface ItemsPage<INPUT = any> {
   count: number;
   page: number;
-  page_size: number;
+  per_page: number;
   results: INPUT[];
 }
 

diff --git a/client/app/components/items-list/classes/StateStorage.js b/client/app/components/items-list/classes/StateStorage.js
@@ -38,7 +38,7 @@ export class UrlStateStorage extends StateStorage {
 
     return {
       page: parseInt(params.page, 10) || defaultState.page,
-      itemsPerPage: parseInt(params.page_size, 10) || defaultState.itemsPerPage,
+      itemsPerPage: parseInt(params.per_page, 10) || defaultState.itemsPerPage,
       orderByField,
       orderByReverse,
       searchTerm,
@@ -50,7 +50,7 @@ export class UrlStateStorage extends StateStorage {
     location.setSearch(
       {
         page,
-        page_size: itemsPerPage,
+        per_page: itemsPerPage,
         order: compileOrderBy(orderByField, orderByReverse),
         q: searchTerm !== "" ? searchTerm : null,
       },

diff --git a/migrations/versions/640888ce445d_.py b/migrations/versions/640888ce445d_.py
@@ -10,8 +10,8 @@
 from alembic import op
 import sqlalchemy as sa
 from sqlalchemy.sql import table
-
-from redash.models import MutableDict, PseudoJSON
+from sqlalchemy.dialects.postgresql import JSON
+from redash.models import MutableDict
 
 
 # revision identifiers, used by Alembic.
@@ -41,7 +41,7 @@ def upgrade():
         "queries",
         sa.Column(
             "schedule",
-            MutableDict.as_mutable(PseudoJSON),
+            MutableDict.as_mutable(JSON),
             nullable=False,
             server_default=json.dumps({}),
         ),
@@ -51,7 +51,7 @@ def upgrade():
     queries = table(
         "queries",
         sa.Column("id", sa.Integer, primary_key=True),
-        sa.Column("schedule", MutableDict.as_mutable(PseudoJSON)),
+        sa.Column("schedule", MutableDict.as_mutable(JSON)),
         sa.Column("old_schedule", sa.String(length=10)),
     )
 
@@ -85,16 +85,16 @@ def downgrade():
         "queries",
         sa.Column(
             "old_schedule",
-            MutableDict.as_mutable(PseudoJSON),
+            MutableDict.as_mutable(JSON),
             nullable=False,
             server_default=json.dumps({}),
         ),
     )
 
     queries = table(
         "queries",
-        sa.Column("schedule", MutableDict.as_mutable(PseudoJSON)),
-        sa.Column("old_schedule", MutableDict.as_mutable(PseudoJSON)),
+        sa.Column("schedule", MutableDict.as_mutable(JSON)),
+        sa.Column("old_schedule", MutableDict.as_mutable(JSON)),
     )
 
     op.execute(queries.update().values({"old_schedule": queries.c.schedule}))
@@ -106,7 +106,7 @@ def downgrade():
         "queries",
         sa.Column("id", sa.Integer, primary_key=True),
         sa.Column("schedule", sa.String(length=10)),
-        sa.Column("old_schedule", MutableDict.as_mutable(PseudoJSON)),
+        sa.Column("old_schedule", MutableDict.as_mutable(JSON)),
     )
 
     conn = op.get_bind()

diff --git a/migrations/versions/73beceabb948_bring_back_null_schedule.py b/migrations/versions/73beceabb948_bring_back_null_schedule.py
@@ -7,10 +7,10 @@
 """
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import postgresql
+from sqlalchemy.dialects.postgresql import JSON
 from sqlalchemy.sql import table
 
-from redash.models import MutableDict, PseudoJSON
+from redash.models import MutableDict
 
 # revision identifiers, used by Alembic.
 revision = "73beceabb948"
@@ -43,7 +43,7 @@ def upgrade():
     queries = table(
         "queries",
         sa.Column("id", sa.Integer, primary_key=True),
-        sa.Column("schedule", MutableDict.as_mutable(PseudoJSON)),
+        sa.Column("schedule", MutableDict.as_mutable(JSON)),
     )
 
     conn = op.get_bind()

diff --git a/migrations/versions/969126bd800f_.py b/migrations/versions/969126bd800f_.py
@@ -6,7 +6,7 @@
 
 """
 
-import simplejson
+import json
 from alembic import op
 import sqlalchemy as sa
 
@@ -27,7 +27,7 @@ def upgrade():
     dashboard_result = db.session.execute("SELECT id, layout FROM dashboards")
     for dashboard in dashboard_result:
         print("  Updating dashboard: {}".format(dashboard["id"]))
-        layout = simplejson.loads(dashboard["layout"])
+        layout = json.loads(dashboard["layout"])
 
         print("    Building widgets map:")
         widgets = {}
@@ -53,7 +53,7 @@ def upgrade():
                 if widget is None:
                     continue
 
-                options = simplejson.loads(widget["options"]) or {}
+                options = json.loads(widget["options"]) or {}
                 options["position"] = {
                     "row": row_index,
                     "col": column_index * column_size,
@@ -62,7 +62,7 @@ def upgrade():
 
                 db.session.execute(
                     "UPDATE widgets SET options=:options WHERE id=:id",
-                    {"options": simplejson.dumps(options), "id": widget_id},
+                    {"options": json.dumps(options), "id": widget_id},
                 )
 
     dashboard_result.close()

diff --git a/migrations/versions/98af61feea92_add_encrypted_options_to_data_sources.py b/migrations/versions/98af61feea92_add_encrypted_options_to_data_sources.py
@@ -15,10 +15,8 @@
 from redash.utils.configuration import ConfigurationContainer
 from redash.models.types import (
     EncryptedConfiguration,
-    Configuration,
     MutableDict,
     MutableList,
-    PseudoJSON,
 )
 
 # revision identifiers, used by Alembic.
@@ -46,7 +44,14 @@ def upgrade():
                 )
             ),
         ),
-        sa.Column("options", ConfigurationContainer.as_mutable(Configuration)),
+        sa.Column(
+            "options",
+            ConfigurationContainer.as_mutable(
+                EncryptedConfiguration(
+                    sa.Text, settings.DATASOURCE_SECRET_KEY, FernetEngine
+                )
+            )
+        ),
     )
 
     conn = op.get_bind()

diff --git a/migrations/versions/d7d747033183_encrypt_alert_destinations.py b/migrations/versions/d7d747033183_encrypt_alert_destinations.py
@@ -16,7 +16,6 @@
 from redash.models.base import key_type
 from redash.models.types import (
     EncryptedConfiguration,
-    Configuration,
 )
 
 
@@ -45,7 +44,14 @@ def upgrade():
                 )
             ),
         ),
-        sa.Column("options", ConfigurationContainer.as_mutable(Configuration)),
+        sa.Column(
+            "options",
+            ConfigurationContainer.as_mutable(
+                EncryptedConfiguration(
+                    sa.Text, settings.DATASOURCE_SECRET_KEY, FernetEngine
+                )
+            )
+        ),
     )
 
     conn = op.get_bind()