enabled hot reload by default

getredash · May 1, 2024 · ef349fe · ef349fe
1 parent 1249885
commit ef349fe
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/bin/docker-entrypoint b/bin/docker-entrypoint
@@ -60,26 +60,30 @@ workers_healthcheck() {
 
 server() {
   # Recycle gunicorn workers every n-th request. See http://docs.gunicorn.org/en/stable/settings.html#max-requests for more details.
+
+  MAX_REQUESTS=${MAX_REQUESTS:-1000}
+  MAX_REQUESTS_JITTER=${MAX_REQUESTS_JITTER:-100}
+  TIMEOUT=${REDASH_GUNICORN_TIMEOUT:-60}
+
+  args=()
   case $REDASH_PRODUCTION in
     true)
       echo "Starting Redash Server in production mode"
-      MAX_REQUESTS=${MAX_REQUESTS:-1000}
-      MAX_REQUESTS_JITTER=${MAX_REQUESTS_JITTER:-100}
-      TIMEOUT=${REDASH_GUNICORN_TIMEOUT:-60}
-      exec /usr/local/bin/gunicorn \
-        -b 0.0.0.0:5000 \
-        --name redash \
-        -w${REDASH_WEB_WORKERS:-4} redash.wsgi:app \
-        --max-requests $MAX_REQUESTS \
-        --max-requests-jitter $MAX_REQUESTS_JITTER \
-        --timeout $TIMEOUT
       ;;
     *)
       echo "Starting Redash Server in a dev mode"
       export FLASK_DEBUG=1
-      exec /app/manage.py runserver --debugger --reload -h 0.0.0.0
+      args+=("--reload")
       ;;
   esac
+  echo "${args[@]}"
+  exec /usr/local/bin/gunicorn \
+    -b 0.0.0.0:5000 \
+    --name redash \
+    -w${REDASH_WEB_WORKERS:-4} redash.wsgi:app \
+    --max-requests $MAX_REQUESTS \
+    --max-requests-jitter $MAX_REQUESTS_JITTER \
+    --timeout $TIMEOUT ${args[@]}
 }
 
 create_db() {

diff --git a/compose.base.yaml b/compose.base.yaml
@@ -19,6 +19,6 @@ services:
       REDASH_ENFORCE_CSRF: true
       REDASH_COOKIE_SECRET: ${REDASH_COOKIE_SECRET}
       REDASH_SECRET_KEY: ${REDASH_SECRET_KEY}
-      REDASH_PRODUCTION: ${REDASH_PRODUCTION:-true}
+      REDASH_PRODUCTION: ${REDASH_PRODUCTION:-false}
     env_file:
       - .env