New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI switched with a checkbox called Use Custom for Oracle #6696
base: master
Are you sure you want to change the base?
Conversation
@snickerjp This PR will probably be of interest to you. 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6696 +/- ##
=======================================
Coverage 63.38% 63.38%
=======================================
Files 162 162
Lines 13165 13165
Branches 1817 1817
=======================================
Hits 8344 8344
Misses 4532 4532
Partials 289 289 |
@snickerjp Actually, would you be interested in reviewing this PR, and also seeing if the concept itself looks good? 😄 |
Looks like a very good concept. |
@snickerjp Ok, so should we merge this as-is? 😄 |
@justinclift Maybe some changes are needed on the query_runner/oracle.py side. |
@snickerjp The full source code for this PR is here: https://github.com/radkmb/redash/tree/toggle-custom-ui It looks like the current Redash https://github.com/radkmb/redash/commits/toggle-custom-ui/ You'll probably need to ask @radkmb about the changes, as I didn't write this code. 😄 |
@radkmb Hopefully you're ok to assist @snickerjp with this? 😄 |
@justinclift I will look into the part that works with query_runner/oracle.py. |
@justinclift |
Ahhh. Thanks for checking @snickerjp. @radkmb Are you ok to look into the above error and fix things? 😄 |
Why do I not have the option to connect to oracle Database |
@sk-on Which version of Redash are you using? 😄 |
What type of PR is this?
Description
Related to #6332 .
This change to the PR changed the UI so that the "Use Custom" checkbox switches the UI instead of the user having to type in a specific string to switch functions.
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
2024-01-09.1.01.08.mov