Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mattermost.py #6738

Closed
wants to merge 2 commits into from
Closed

Update mattermost.py #6738

wants to merge 2 commits into from

Conversation

kolya7k
Copy link

@kolya7k kolya7k commented Feb 1, 2024

Fix UnicodeEncodeError for non-Latin characters for mattermost destination (#6715)

Fix UnicodeEncodeError for non-Latin characters for mattermost destination (#6715)
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.37%. Comparing base (af0773c) to head (4e48329).
Report is 34 commits behind head on master.

❗ Current head 4e48329 differs from pull request most recent head 4e8fa07. Consider uploading reports for the commit 4e8fa07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6738      +/-   ##
==========================================
- Coverage   63.82%   63.37%   -0.45%     
==========================================
  Files         161      162       +1     
  Lines       13060    13170     +110     
  Branches     1803     1819      +16     
==========================================
+ Hits         8335     8347      +12     
- Misses       4425     4532     +107     
+ Partials      300      291       -9     
Files Coverage Δ
redash/destinations/mattermost.py 32.35% <0.00%> (ø)

... and 21 files with indirect coverage changes

@guidopetri
Copy link
Collaborator

@kolya7k thanks for the PR! While you're at it, do you think we should update all destinations to support UTF8?

@kolya7k
Copy link
Author

kolya7k commented Feb 3, 2024

Yes, but i encountered with this problem on MM because i'm using MM and Cyrillic symbols :)
I can later make a PR for every destination

@guidopetri
Copy link
Collaborator

Could we do it in this PR since it's a one line change?

@eradman
Copy link
Collaborator

eradman commented Apr 25, 2024

Rebasing to see if tests pass

@kolya7k kolya7k closed this by deleting the head repository May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants