Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS S3 Query runner #6755

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rameshramachandran2
Copy link

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • [ x] New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

I have created a new Query Runner - AWS S3 Datasource. This will be compatible with all the versions

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • [ x] Manually
  • N/A

We did multiple rounds of testing with various use cases and the tests passed.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@eradman
Copy link
Collaborator

eradman commented Feb 26, 2024

@RameshRamachandran:

  1. can you provide an example screenshot?
  2. see if you can put together a test for this feature under tests/query_runner/
  3. try rebasing to see if this fixes the checks that failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants