Front end data type display exception #6888
Conversation
|
Thank you very much for your contribution. To finally solve this problem, you need to introduce the bigint library. The current solution has not completely solved it. 😉 |
|
GPT told me something about |
|
@gaecoli why is the test is failing? |
https://github.com/getredash/redash/wiki/The-list-of-Redash-make-commands Your code format does not conform to our style. You should run |
|
@mirkan1 Was this code written using an LLM (ChatGPT, or any other)? |
|
@justinclift I asked a few question to Chat GPT for BigInt but the other way around is writing a fix into numeral library itself |
|
I wrote a version upgrade for numeral yet I dont know if the maintainer will merge it any time soon... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6888 +/- ##
=======================================
Coverage 63.83% 63.83%
=======================================
Files 161 161
Lines 13094 13094
Branches 1814 1814
=======================================
Hits 8359 8359
Misses 4432 4432
Partials 303 303 |
client/app/services/query-result.js
Outdated
| @@ -5,6 +5,7 @@ import { QueryResultError } from "@/services/query"; | |||
| import { Auth } from "@/services/auth"; | |||
| import { isString, uniqBy, each, isNumber, includes, extend, forOwn, get } from "lodash"; | |||
|
|
|||
| const JSONbigString = require("json-bigint")({ storeAsString: true }); | |||
There was a problem hiding this comment.
This code can be changed import style? In order to unify the code style of the entire project, it is recommended to use import to import the package.
There was a problem hiding this comment.
And change JSONbigString to jsonParse?
|
PTAL @justinclift |
This reverts commit 2c27db5.
|
@eradman would it make any diffirence to store integers as string on |
There would imply a complicated migration because |
This reverts commit 5848c62.
This is a fix for #6159