moved cypress out of container

.dockerignore

@@ -1,4 +1,5 @@
 client/.tmp/
+client/cypress/
 node_modules/
 viz-lib/node_modules/
 .tmp/
@@ -12,3 +13,8 @@ venv/
 /.github/
 /netlify.toml
 /setup/
+.github/
+compose.*
+*.md
+LICENSE*
+Dockerfile*

.github/workflows/ci.yml

@@ -10,6 +10,7 @@ on:
       - master
 env:
   CYPRESS_COVERAGE: "true"
+  CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/node_modules/.cache/Cypress
   NODE_VERSION: 18
   YARN_VERSION: 1.22.22
   REDASH_COOKIE_SECRET: 2H9gNG9obnAQ9qnR9BDTQUph6CbXKCzF
@@ -149,10 +150,7 @@ jobs:
     runs-on: ubuntu-22.04
     needs: frontend-lint
     env:
-      CYPRESS_INSTALL_BINARY: 0
-      PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 1
       INSTALL_GROUPS: main
-      COMPOSE_PROFILES: e2e
       PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
       CYPRESS_PROJECT_ID: ${{ secrets.CYPRESS_PROJECT_ID }}
       CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
@@ -179,8 +177,7 @@ jobs:
           touch .env
           yarn build
           yarn cypress build
-          yarn cypress start -- --skip-db-seed
-          docker compose run cypress yarn cypress db-seed
+          yarn cypress start
       - name: Execute Cypress Tests
         run: yarn cypress run-ci
       - name: "Failure: output container logs to console"

Dockerfile

@@ -20,11 +20,10 @@ ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
 RUN useradd -m -d /frontend redash
 USER redash
 WORKDIR /frontend
-COPY --chown=redash package.json yarn.lock .yarnrc /frontend/
+COPY --chown=redash package.json yarn.lock /frontend/
 COPY --chown=redash viz-lib /frontend/viz-lib
-COPY --chown=redash scripts /frontend/scripts
 
-RUN yarn --frozen-lockfile --network-concurrency 1;
+RUN yarn --frozen-lockfile --network-concurrency 1
 COPY --chown=redash client /frontend/client
 COPY --chown=redash webpack.config.js /frontend/
 RUN yarn build

Makefile

@@ -2,7 +2,6 @@
 
 export COMPOSE_DOCKER_CLI_BUILD=1
 export DOCKER_BUILDKIT=1
-export COMPOSE_PROFILES=local
 
 compose_build: .env
 	docker compose build
@@ -28,12 +27,7 @@ create_database: create_db
 
 clean:
 	docker compose down
-	docker compose --project-name cypress down
 	docker compose rm --stop --force
-	docker compose --project-name cypress rm --stop --force
-	docker image rm --force \
-		cypress-server:latest cypress-worker:latest cypress-scheduler:latest \
-		redash-server:latest redash-worker:latest redash-scheduler:latest
 	docker container prune --force
 	docker image prune --force
 	docker volume prune --force

client/cypress/cypress.js

@@ -1,45 +1,5 @@
 /* eslint-disable import/no-extraneous-dependencies, no-console */
-const { find } = require("lodash");
 const { execSync } = require("child_process");
-const { get, post } = require("request").defaults({ jar: true });
-const { seedData } = require("./seed-data");
-const fs = require("fs");
-var Cookie = require("request-cookies").Cookie;
-
-let cypressConfigBaseUrl;
-try {
-  const cypressConfig = JSON.parse(fs.readFileSync("cypress.json"));
-  cypressConfigBaseUrl = cypressConfig.baseUrl;
-} catch (e) {}
-
-const baseUrl = process.env.CYPRESS_baseUrl || cypressConfigBaseUrl || "http://localhost:5001";
-
-function seedDatabase(seedValues) {
-  get(baseUrl + "/login", (_, { headers }) => {
-    const request = seedValues.shift();
-    const data = request.type === "form" ? { formData: request.data } : { json: request.data };
-
-    if (headers["set-cookie"]) {
-      const cookies = headers["set-cookie"].map(cookie => new Cookie(cookie));
-      const csrfCookie = find(cookies, { key: "csrf_token" });
-      if (csrfCookie) {
-        if (request.type === "form") {
-          data["formData"] = { ...data["formData"], csrf_token: csrfCookie.value };
-        } else {
-          data["headers"] = { "X-CSRFToken": csrfCookie.value };
-        }
-      }
-    }
-
-    post(baseUrl + request.route, data, (err, response) => {
-      const result = response ? response.statusCode : err;
-      console.log("POST " + request.route + " - " + result);
-      if (seedValues.length) {
-        seedDatabase(seedValues);
-      }
-    });
-  });
-}
 
 function buildServer() {
   console.log("Building the server...");
@@ -67,10 +27,12 @@ function runCypressCI() {
     process.env.CYPRESS_OPTIONS = "--record";
   }
 
-  execSync(
-    "docker compose run --name cypress cypress ./node_modules/.bin/percy exec -t 300 -- ./node_modules/.bin/cypress run $CYPRESS_OPTIONS",
-    { stdio: "inherit" }
-  );
+  // Remove four lines below after it's merged
+  delete process.env.CYPRESS_INSTALL_BINARY;
+  execSync("rm -r node_modules", { stdio: "inherit" });
+  execSync("yarn install", { stdio: "inherit" });
+
+  execSync("yarn percy cypress run $CYPRESS_OPTIONS", { stdio: "inherit" });
 }
 
 const command = process.argv[2] || "all";
@@ -81,12 +43,6 @@ switch (command) {
     break;
   case "start":
     startServer();
-    if (!process.argv.includes("--skip-db-seed")) {
-      seedDatabase(seedData);
-    }
-    break;
-  case "db-seed":
-    seedDatabase(seedData);
     break;
   case "run":
     execSync("cypress run", { stdio: "inherit" });
@@ -95,18 +51,18 @@ switch (command) {
     execSync("cypress open", { stdio: "inherit" });
     break;
   case "run-ci":
+    execSync("docker compose run server create_db", { stdio: "inherit" });
     runCypressCI();
     break;
   case "stop":
     stopServer();
     break;
   case "all":
     startServer();
-    seedDatabase(seedData);
     execSync("cypress run", { stdio: "inherit" });
     stopServer();
     break;
   default:
-    console.log("Usage: yarn cypress [build|start|db-seed|open|run|stop]");
+    console.log("Usage: yarn cypress [build|start|open|run|stop]");
     break;
 }

client/cypress/integration/group/edit_group_spec.js

@@ -7,7 +7,7 @@ describe("Edit Group", () => {
   it("renders the page and takes a screenshot", () => {
     cy.getByTestId("Group").within(() => {
       cy.get("h3").should("contain", "admin");
-      cy.get("td").should("contain", "Example Admin");
+      cy.get("td").should("contain", Cypress.env("CYPRESS_LOGIN_NAME"));
     });
 
     cy.percySnapshot("Group");

client/cypress/integration/user/create_user_spec.js

@@ -17,8 +17,7 @@ describe("Create User", () => {
     cy.request("GET", "api/users?q=new-user")
       .then(({ body }) => body.results.filter(user => user.email === "new-user@redash.io"))
       .each(user => cy.request("DELETE", `api/users/${user.id}`));
-
-    fillUserFormAndSubmit("New User", "admin@redash.io");
+    fillUserFormAndSubmit("New User", Cypress.env("CYPRESS_LOGIN_EMAIL"));
 
     cy.getByTestId("CreateUserErrorAlert").should("contain", "Email already taken");
 

client/cypress/integration/user/edit_profile_spec.js

@@ -24,7 +24,7 @@ describe("Edit Profile", () => {
       .should("eq", 200);
     cy.visit("/users/me");
     cy.contains("Jian Yang");
-    fillProfileDataAndSave("Example Admin", "admin@redash.io");
+    fillProfileDataAndSave("Example Admin", Cypress.env("CYPRESS_LOGIN_EMAIL"));
   });
 
   it("regenerates API Key", () => {
@@ -51,15 +51,16 @@ describe("Edit Profile", () => {
     });
 
     it("updates user password when password is correct", () => {
-      fillChangePasswordAndSave("password", "newpassword", "newpassword");
+      const password = Cypress.env("CYPRESS_LOGIN_PASSWORD") || "password";
+      fillChangePasswordAndSave(password, "newpassword", "newpassword");
       cy.contains("Saved.");
       cy.logout();
       cy.login(undefined, "newpassword")
         .its("status")
         .should("eq", 200);
       cy.visit("/users/me");
       cy.getByTestId("ChangePassword").click();
-      fillChangePasswordAndSave("newpassword", "password", "password");
+      fillChangePasswordAndSave("newpassword", password, password);
       cy.contains("Saved.");
     });
 

client/cypress/integration/user/login_spec.js

@@ -11,15 +11,15 @@ describe("Login", () => {
   });
 
   it("shows message on failed login", () => {
-    cy.getByTestId("Email").type("admin@redash.io");
+    cy.getByTestId("Email").type(Cypress.env("CYPRESS_LOGIN_EMAIL"));
     cy.getByTestId("Password").type("wrongpassword{enter}");
 
     cy.getByTestId("ErrorMessage").should("contain", "Wrong email or password.");
   });
 
   it("navigates to homepage with successful login", () => {
-    cy.getByTestId("Email").type("admin@redash.io");
-    cy.getByTestId("Password").type("password{enter}");
+    cy.getByTestId("Email").type(Cypress.env("CYPRESS_LOGIN_EMAIL"));
+    cy.getByTestId("Password").type(`${Cypress.env("CYPRESS_LOGIN_PASSWORD")}{enter}`);
 
     cy.title().should("eq", "Redash");
     cy.get(`img.profile__image_thumb[alt="Example Admin"]`).should("exist");