Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): Escape assignee dropdown input #71105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isabellaenriquez
Copy link
Member

Fixes SENTRY-2MBQ

@isabellaenriquez isabellaenriquez requested a review from a team May 17, 2024 14:20
@isabellaenriquez isabellaenriquez requested a review from a team as a code owner May 17, 2024 14:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (23f1d18) to head (69f9da2).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71105      +/-   ##
==========================================
- Coverage   77.90%   77.90%   -0.01%     
==========================================
  Files        6552     6552              
  Lines      291463   291465       +2     
  Branches    50419    50419              
==========================================
- Hits       227072   227071       -1     
- Misses      58132    58135       +3     
  Partials     6259     6259              
Files Coverage Δ
...sentry/integrations/slack/webhooks/options_load.py 96.22% <100.00%> (+4.06%) ⬆️

... and 5 files with indirect coverage changes

self.store_event(data=self.event_data, project_id=self.project.id)

# shouldn't fail
resp = self.post_webhook(substring="Al[", original_message=self.original_message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why [? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my question is what was the problem for it not working before? Trying to learn 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants