-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(context): Track progress of preloading requests #71112
Merged
cathteng
merged 11 commits into
master
from
seiji/chore/add-loading-state-to-org-loader-context
May 21, 2024
Merged
chore(context): Track progress of preloading requests #71112
cathteng
merged 11 commits into
master
from
seiji/chore/add-loading-state-to-org-loader-context
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
May 17, 2024
schew2381
force-pushed
the
seiji/chore/add-loading-state-to-org-loader-context
branch
from
May 17, 2024 23:48
84ceaf0
to
1d865fc
Compare
Bundle ReportChanges will increase total bundle size by 198 bytes ⬆️
|
schew2381
changed the title
chore(context): Track org loading state progress
chore(context): Track progress of preloading requests
May 17, 2024
saponifi3d
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 nice!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of when the organization is loading in
OrganizationContextProvider
so we can fetch the loading state fromOrganizationLoadingContext
.Most useful stackoverflow post ever.