Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(context): Track progress of preloading requests #71112

Merged
merged 11 commits into from
May 21, 2024

Conversation

schew2381
Copy link
Member

@schew2381 schew2381 commented May 17, 2024

Keep track of when the organization is loading in OrganizationContextProvider so we can fetch the loading state from OrganizationLoadingContext.

Most useful stackoverflow post ever.

@schew2381 schew2381 force-pushed the seiji/chore/add-loading-state-to-org-loader-context branch from 84ceaf0 to 1d865fc Compare May 17, 2024 23:48
@schew2381 schew2381 requested review from a team, saponifi3d and cathteng May 17, 2024 23:49
Copy link

codecov bot commented May 17, 2024

Bundle Report

Changes will increase total bundle size by 198 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.66MB 198 bytes ⬆️

@schew2381 schew2381 changed the title chore(context): Track org loading state progress chore(context): Track progress of preloading requests May 17, 2024
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 nice!

@schew2381 schew2381 marked this pull request as ready for review May 20, 2024 16:46
@cathteng cathteng merged commit c6793a9 into master May 21, 2024
44 checks passed
@cathteng cathteng deleted the seiji/chore/add-loading-state-to-org-loader-context branch May 21, 2024 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants