perf(issue-stream): Ensure that changing the selected issues does not rerender the entire row #71139
+40
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rerender the the entire row
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
May 17, 2024
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
… rerender the entire row (#71139) Moves the checkbox and SelectedGroupStore listener to its own component so that it doesn't cause the entire row to rerender (which is expensive with so many on the page).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the checkbox and SelectedGroupStore listener to its own component so that it doesn't cause the entire row to rerender (which is expensive with so many on the page). This doesn't completely solve #71134, but does make it more difficult to reproduce.