Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug on avatar #31008

Merged
merged 2 commits into from
May 19, 2024
Merged

Fix bug on avatar #31008

merged 2 commits into from
May 19, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented May 17, 2024

Extract from #30995

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels May 17, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 17, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 17, 2024
kemzeb
kemzeb approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@kemzeb kemzeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Was questioning why we now fire up a transaction here but now I see it's because we should rollback in case we face any failures deleting the avatar from object storage 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2024
@wxiaoguang wxiaoguang merged commit 58a03e9 into go-gitea:main May 19, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 19, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 19, 2024
@lunny @silverwind @GiteaBot
Fix bug on avatar (go-gitea#31008)
c7536f5 
Co-authored-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot mentioned this pull request May 19, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 19, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 20, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
ab16ce1 
* giteaofficial/main:
  Fix "force private" logic (go-gitea#31012)
  [skip ci] Updated licenses and gitignores
  Improve reverse proxy documents and clarify the AppURL guessing behavior (go-gitea#31003)
  Fix bug on avatar (go-gitea#31008)
  Clean up revive linter config, tweak golangci output (go-gitea#30980)
  Simplify mirror repository API logic (go-gitea#30963)
@lunny lunny deleted the lunny/add_transaction_delete_avatar branch May 20, 2024 01:56
lunny added a commit that referenced this pull request May 20, 2024
@GiteaBot @lunny @silverwind
Fix bug on avatar (#31008) (#31019)
8446caa 
Backport #31008 by @lunny

Extract from #30995

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@kemzeb kemzeb kemzeb approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @silverwind @kemzeb @wxiaoguang @GiteaBot