feat(transport/grpc,contrib): add NewClient method to gRPC client(#3312) #3323
Conversation
…kratos#3312) * feat: update grpc v1.63.x * feat: use NewClient method replace Dial in gRPC client * test: update grpc client test case * docs: update README.md
dosubot
bot
added
the
size:M
| func Dial(ctx context.Context, opts ...ClientOption) (*grpc.ClientConn, error) { | ||
| return dial(ctx, false, opts...) | ||
| options, grpcOpts := makeOptions(false, opts...) | ||
| return dial(ctx, options, grpcOpts) |
There was a problem hiding this comment.
Dial has been deprecated. Can use NewClient directly? For example: return NewClient(opts...)
There was a problem hiding this comment.
The NewClient function can be used directly;
However, the original timeout and block connection logic supported by the gRPC Dial will be completely discarded, rendering them incompatible.
For the sake of compatibility, it's advisable to follow the same pattern as the grpc-go library
Anti-Patterns of Client creation
For these reasons, using grpc.Dial is discouraged. Even though it is marked as deprecated, we will continue to support it until a v2 is released (and no plans for a v2 exist at the time this was written).
merely annotating the deprecated features. These can then be fully removed in a future major version update.
Ultimately, this decision hinges on the project maintainer's perspective. If deemed necessary, direct replacement without regard for the original logic's compatibility can be pursued. I will do this.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
resolves: #3312
Other special notes for the reviewers: