Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token service returning empty token on tls certificate issue without any error #20081

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dee-kryvenko
Copy link

@dee-kryvenko dee-kryvenko commented Mar 3, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20080

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…out any error

Signed-off-by: Dee Kryvenko <dee@selfcloud.tech>
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label May 18, 2024
@dee-kryvenko
Copy link
Author

Not stale.

@github-actions github-actions bot removed the Stale label May 19, 2024
@Vad1mo Vad1mo added the release-note/update Update or Fix label May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.13%. Comparing base (b7b8847) to head (f6878be).
Report is 206 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20081      +/-   ##
==========================================
+ Coverage   67.56%   69.13%   +1.56%     
==========================================
  Files         991      795     -196     
  Lines      109181    99416    -9765     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68728    -5040     
+ Misses      31449    26950    -4499     
+ Partials     3964     3738     -226     
Flag Coverage Δ
unittests 69.13% <0.00%> (+1.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/token/token.go 54.34% <0.00%> (+4.34%) ⬆️

... and 321 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On tls issues with the certificate - token service returns empty token without any error or log record
7 participants