-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enconding/json: add ValidPos() function #67422
Conversation
This returns the position on which the validation failed.
This PR (HEAD: 9adaed7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585995. Important tips:
|
We use Example usage: package main
import (
"encoding/json"
"fmt"
"strings"
)
func main() {
inputs := []string{
`{}`,
`{"foo": "bar"}`,
`{"foo: "bar"}`,
`{"foo": "bar", "bar": foo}`,
`{"foo": "bar", "bar", foo}`,
}
for _, input := range inputs {
v, pos := json.ValidPos([]byte(input))
fmt.Printf("'%s': valid: %#v, pos: %d\n", input, v, pos)
if !v {
fmt.Printf(strings.Repeat(" ", int(pos)) + "^\n")
}
}
} Output:
This would make it easier to see why validation failed, especially for larger JSON documents. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585995. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/585995. |
Message from Daniël van Eeden: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585995. |
Add json.ValidPos() to allow getting the position of where the validation failed
in addition to a boolean to indicate the failure.
Closes #67423