-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/fmtsort: use cmp.Compare for value comparisons #67454
Conversation
Refactor compare function to use cmp.Compare for various types. Remove redundant floatCompare and isNaN functions.
This PR (HEAD: d98365c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586239. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Zhen Li: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from qiu laidongfeng2: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-17T06:28:07Z","revision":"1cec43a30ce62060f451126681c9726ac64b17a2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from qiu laidongfeng2: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-18T15:08:43Z","revision":"52a946c1762b08c5132fd4c56a98916024753261"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586239. |
Refactor compare function to use cmp.Compare for various types. Remove redundant floatCompare and isNaN functions. Change-Id: I146a7af9158538499d07daee930aad8cf89b7e8f GitHub-Last-Rev: d98365c GitHub-Pull-Request: #67454 Reviewed-on: https://go-review.googlesource.com/c/go/+/586239 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/586239 has been merged. |
Refactor compare function to use cmp.Compare for various types.
Remove redundant floatCompare and isNaN functions.