-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: replace sort with slices for address and DNS record sorting #67503
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: bf7c9ab) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586635. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Zhen Li: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-18T17:32:30Z","revision":"df48e07a22e16213df5129a290a036c785d6f7db"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Damien Neil: Patch Set 1: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
Message from Zhen Li: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586635. |
This change replaces the usage of the "sort" package with the "slices" package for sorting IP addresses and DNS records. The new approach simplifies the code and improves readability by leveraging the slices.SortFunc and slices.SortStableFunc functions. - Updated addrselect.go to use slices.SortStableFunc for sorting IP addresses based on RFC 6724. This change also reduces the dependency tree for the package by removing the dependency on "sort" and its transitive dependencies, resulting in a leaner build.
This PR (HEAD: 3720a49) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586635. Important tips:
|
This change replaces the usage of the "sort" package with the "slices"
package for sorting IP addresses and DNS records. The new approach
simplifies the code and improves readability by leveraging the
slices.SortFunc and slices.SortStableFunc functions.
addresses based on RFC 6724.
records by priority and weight.
This change also reduces the dependency tree for the package by
removing the dependency on "sort" and its transitive dependencies,
resulting in a leaner build.