Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add codec support for HLS (m3u8 and m3u formats) #1592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbgomez
Copy link

@jbgomez jbgomez commented Apr 18, 2022

Issue/Feature

  • Add support for HLS file formats m3u8 and m3u.
  • Fix bug where codec setup can execute more than once.

Solution

  • Add HLS support via media type defined here.
  • Change initial _codecs value to null to prevent _setupCodecs from executing more than once.

Reproduction/Testing

Native HLS support in Safari demo: https://developer.apple.com/streaming/examples/advanced-stream-ts.html

Breaking Changes

None.

@wasauce
Copy link

wasauce commented May 31, 2022

this is a great PR. We would love to see this merged (and plan to make use of this). Is there something we can do to promote this or help see it merged?

@jbgomez
Copy link
Author

jbgomez commented Jun 3, 2022

Thanks, @wasauce.

@goldfire, please let us know if there's anything we can do to help. We appreciate your work on this library!

@nam-nguyen-niteco
Copy link

@jbgomez your codepen doesn't exist. I've tried playing a HLS file but did not work

@jbgomez
Copy link
Author

jbgomez commented Jun 23, 2022

@nam-nguyen-niteco sorry, I must have deleted that CodePen by mistake. I have replaced the CodePen link with a demo from Apple's developer website. This demo is simply meant to showcase native application/vnd.apple.mpegurl support in Safari, which this PR would effectively ungate for Howler.js. To be clear, this PR does not implement HLS support for browsers that do not already natively support the application/vnd.apple.mpegurl media type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants