Added support for passing audio data as an ArrayBuffer #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue/Feature
While working on a project we encountered the need to preload our audio assets with a custom loader. While it appeared that we could preload the audio assets and then pass them in as a base64 data URI, we ran into similar issues as referenced here: #1257
Related Issues
#1257
Solution
Our solution was to add an additional parameter called 'arraybuffer', which if set to an ArrayBuffer, would be decoded directly.
Reproduction/Testing
To test you simply need to pass in an ArrayBuffer from a loaded audio file.
*Note: you still need to pass in a url to src so that the audio buffer can be cached.
Breaking Changes
N/A