-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide formatters shortcuts #811
Conversation
Signed-off-by: Anil Kumar Behera <ark845612@gmail.com>
This reverts commit ebf8048.
Signed-off-by: Anil Kumar Behera <ark845612@gmail.com>
@@ -226,6 +226,21 @@ describe('core', () => { | |||
assert.equal((await p).toString(), 'foo\n') | |||
}) | |||
|
|||
test('ProcessPromise: implements json()', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ProcessPromise
here but ProcessOutput
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for text()
and buffer()
? I just followed toString()
test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antongolub should I also change ProcessOutput
for toString()
test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will land the rest part in another PR
continues google#811 relates google#764
Fixes #764
json()
,'text()
,bufffer()
.json()
,'text()
,bufffer()
.Not sure about the stream function. Would like to have more context.