Updates/permute #10
Open
Updates/permute #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotzmann
requested changes
Apr 20, 2023
| @@ -784,25 +784,12 @@ func NewTensor(ctx *Context, dt DType, dims uint32, ne0, ne1, ne2, ne3 uint32, d | |||
| return &result | |||
| } | |||
|
|
|||
| // ggml_permute | |||
There was a problem hiding this comment.
I'd prefer to store original GGML function names for easier navigation between projects :)
| func Permute(ctx *Context, a *Tensor, axis0, axis1, axis2, axis3 uint32) *Tensor { | ||
|
|
||
| ////ASSERT(axis0 >= 0 && axis0 < MAX_DIMS); |
There was a problem hiding this comment.
And all the ASSERTs should be moved into special place to re-enable them on the graph init to be sure there no problems with dimensions and data types between tensors.
So yeah, the code is ugly right now, but please do not remove important parts which I'm going to move from there a bit later.
| } | ||
|
|
||
| target := rng.Float32() * cumulative[len(cumulative)-1] | ||
| idx := sort.Search(len(cumulative), func(i int) bool { return cumulative[i] >= target }) |
There was a problem hiding this comment.
I've tested this and seems, it doesn't doing well yet. Like this debug example, where most probable logit #0 was ignored and #4 with zero probability was chosen instead:
=== OLD === 0.017 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | === idx = 0 | logitsID = 372 | weight = 21.167
=== NEW === 0.017 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | 0.000 | === idx = 4 | logitsID = 756 | weight = 17.544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.