Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the client correctly handles all binary data #8322

Merged
merged 5 commits into from
May 21, 2024

Conversation

Saghen
Copy link
Contributor

@Saghen Saghen commented May 17, 2024

Description

The walk_and_store_blobs function was ignoring blobs that were directly inside of arrays such as [blob] due to the map using the blob value as the key, rather than the index.

Closes: #7778

@Saghen Saghen changed the title fix: walk blobs ignoring blobs in arrays directly Walk blobs ignoring blobs in arrays directly May 17, 2024
@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 17, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a8eb801a6b03874834d8ea29b576760602d020a6/gradio-4.31.4-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a8eb801a6b03874834d8ea29b576760602d020a6#subdirectory=client/python"

@gradio-pr-bot
Copy link
Contributor

gradio-pr-bot commented May 20, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

ensure the client correctly handles all binary data

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@pngwn pngwn changed the title Walk blobs ignoring blobs in arrays directly ensure the client correctly handles all binary data May 21, 2024
@pngwn pngwn enabled auto-merge (squash) May 21, 2024 19:58
@pngwn pngwn merged commit 47012a0 into gradio-app:main May 21, 2024
7 checks passed
@pngwn pngwn mentioned this pull request May 21, 2024
@Saghen Saghen deleted the fix/array-blob-upload branch May 21, 2024 21:58
@Saghen
Copy link
Contributor Author

Saghen commented May 21, 2024

thank you!

This was referenced Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js gradio client api upload image error
4 participants