Spike: capture latency of build cache HTTP requests #29146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lptr
force-pushed
the
lptr/build-cache/capture-latency
branch
from
dd888db
to
2895a8c
Compare
lptr
force-pushed
the
lptr/build-cache/capture-latency
branch
from
1b142b2
to
5827114
Compare
|
@bot-gradle test QFL please. |
|
I've triggered the following builds for you. Click here to see all build failures. |
lptr
changed the title
welandaz
reviewed
May 17, 2024
| public BuildOperationDescriptor.Builder description() { | ||
| return BuildOperationDescriptor.displayName("HTTP " + request.getMethod() + " request for cache key " + key.getHashCode()); | ||
| } | ||
| }); |
There was a problem hiding this comment.
What kind of build operation is emitted in this case? Does it correlate somehow with load/store operation that's also emitted in this context
There was a problem hiding this comment.
Right now this is just an anonymous operation, but as mentioned in the description, we'll need to create a BuildOperationType to be able to properly identify it in the scan plugin.
This build operation is nested within the relevant remote load / remote store build operation.
|
Closing this as the experiment is now concluded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture the latency of HTTP requests to the build cache as a new build operation.
Findings:
HttpBuildCacheService, which uses Apache HttpClient 4.x.BasicHttpEntity; this has an 8 KB buffer, which will be read as part of the captured build operation. For small cache artifacts this means that the entire artifact's download time would be part of the measured latency.If we want to use this approach, we need to introduce a new build operation type in
:enterprise-operations. We'll need to reuse this same type in the Develocity HTTP cache client, too, and the scans plugin needs to handle this build operation going forward.Reviewing cheatsheet
Before merging the PR, comments starting with