Reimplement reporting error and warning count when a compilation error happens #29183
+160
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hegyibalint
changed the title
hegyibalint
added
a:regression
donat
requested changes
May 22, 2024
.../src/integTest/groovy/org/gradle/api/tasks/compile/JavaCompileProblemsIntegrationTest.groovy
Show resolved
Hide resolved
...ge-java/src/main/java/org/gradle/api/internal/tasks/compile/DiagnosticToProblemListener.java
Outdated
Show resolved
Hide resolved
Comment on lines
86
to
110
| /** | ||
| * This method is based on {JavaCompiler#printCount()} | ||
| */ |
There was a problem hiding this comment.
❌ The javadoc should state the following:
- functionality: this method prints the number of warnings / errors to the standard output
- intent: when there's no diagnostic listener attached to the compiler object, the number of warnings/errors are part of the putput. Since we have a listener attached, the output changed. Calling this method makes restores compatiblity with the original output
- source: the method implementation is based on {JavaCompiler#printCount()}.
There was a problem hiding this comment.
Added further documentation
| @@ -63,6 +63,7 @@ public WorkResult execute(JavaCompileSpec spec) { | |||
| ApiCompilerResult result = new ApiCompilerResult(); | |||
| JavaCompiler.CompilationTask task = createCompileTask(spec, result); | |||
| boolean success = task.call(); | |||
| diagnosticToProblemListener.reportDiagnosticCounts(); | |||
There was a problem hiding this comment.
❓ Will we hit this code path when we do joint Java-Groovy compilation?
There was a problem hiding this comment.
Added a new integration test verifying this
donat
requested changes
May 29, 2024
...y/src/integTest/groovy/org/gradle/groovy/compile/GroovyCompileProblemsIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...y/src/integTest/groovy/org/gradle/groovy/compile/GroovyCompileProblemsIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
| * /.../Bar.java:10: warning: [cast] redundant cast to String | ||
| * String s = (String)"Hello World"; | ||
| * ^ | ||
| * 1 error |
There was a problem hiding this comment.
Just to validate: do we have coverage when we have 0 errors and/or 1 warnings on the output?
donat
force-pushed
the
bhegyi/problems/java-compile/emit-error-count
branch
from
387f400
to
193c3f7
Compare
|
@bot-gradle test this |
|
I've triggered the following builds for you. Click here to see all build failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new problem reporting framework was introduced, we didn't yet implement the error counters.
E.g., the following output from
javachas a count at the end (note on the bottom the counters)This PR adds these counters back.