-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing toolchain tests #29192
Fix failing toolchain tests #29192
Conversation
Stacktraces were being written to info logs even when no real failure was occurring
Fixes issues with provisioning not triggering
...al-integ-testing/src/main/groovy/org/gradle/test/preconditions/IntegTestPreconditions.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Bo Zhang <bo@gradle.com> Signed-off-by: Octavia Togami <octavia.togami@gmail.com>
@bot-gradle help |
Currently, the following commands are supported:
|
@bot-gradle test AllCrossVersionTestsReadyForNightly AllSmokeTestsPullRequestFeedback |
I've triggered the following builds for you. Click here to see all build failures. |
The merge queue build has failed. Click here to see all failures. |
.../gradle/jvm/toolchain/internal/install/ProvisionedJdkReuseCrossVersionIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...al-integ-testing/src/main/groovy/org/gradle/test/preconditions/IntegTestPreconditions.groovy
Outdated
Show resolved
Hide resolved
c23f492
to
22b3e01
Compare
The merge queue build has failed. Click here to see all failures. |
Fixes https://github.com/gradle/gradle-private/issues/4195, fixes https://github.com/gradle/gradle-private/issues/4198, as well as additional issues with assertions failing when the current JDK matched the spec. These tests are now specifically designed to have a spec that will never match the current JDK.
Reviewing cheatsheet
Before merging the PR, comments starting with