Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy require support #3694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop legacy require support #3694

wants to merge 1 commit into from

Conversation

mstoykov
Copy link
Collaborator

What?

Completely drop the legacy require support

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.53.0 milestone Apr 19, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 19, 2024 09:42
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 19, 2024 09:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 70.87%. Comparing base (93649df) to head (2961d5a).

Current head 2961d5a differs from pull request most recent head af21b6f

Please upload reports for the commit af21b6f to get more accurate results.

Files Patch % Lines
js/bundle.go 77.77% 2 Missing and 2 partials ⚠️
js/modules/resolution.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   70.88%   70.87%   -0.01%     
==========================================
  Files         291      288       -3     
  Lines       21226    21183      -43     
==========================================
- Hits        15045    15013      -32     
+ Misses       5216     5206      -10     
+ Partials      965      964       -1     
Flag Coverage Δ
ubuntu 70.87% <80.95%> (+0.03%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from requireWarning to master April 22, 2024 12:28
return r.modSys.Require(specifier)
}

// getPreviousRequiringFile is a helper that is currently need for the implemnetation of `open`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// getPreviousRequiringFile is a helper that is currently need for the implemnetation of `open`.
// getPreviousRequiringFile is a helper that is currently need for the implementation of `open`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants