Show real proxy hostnames in VNet UI #41715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
the
no-changelog
ravicious
force-pushed
the
r7s/ui-dns-zones
branch
from
8227d5e
to
7df6741
Compare
zmb3
approved these changes
May 18, 2024
gzdunek
approved these changes
May 20, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
ravicious
force-pushed
the
r7s/teleterm-vnet
branch
from
9e3ca78
to
1dc9fb2
Compare
ravicious
force-pushed
the
r7s/ui-dns-zones
branch
from
7df6741
to
675136d
Compare
This makes it easier to converting profileName + leafName combos into URIs.
lib/teleterm cannot reuse this function due to different semantics of contexts within an RPC vs a CLI command. It needs one function that has request-response semantics and another that blocks that can be run from a separate goroutine.
Without this extra select on ctx.Done, interrupting tsh vnet at that moment would return an error about using a closed socket. That's because when the context gets canceled, another goroutine closes the socket. Instead, we should wait for either the cancelation of the context or socket.AcceptUnix returning a value. To test this, run `tsh vnet`. When the osascript prompt is shown, go back to the terminal and Ctrl+C the command. The previous version would show an error about using closed connection whereas this exits cleanly.
The previous version would show "context canceled" after sending SIGINT to tsh vnet after the user entered the password in the prompt and the TUN device was set up.
If the socket file was removed, the admin subcommand stops. The previous version of VNet would continue running. This version correctly propagates the fact that the admin subcommand has quit prematurely with no error and shuts down vnet.Manager as well.
Because of the changes from a couple of commits ago related to ignoring context.Canceled errors, if the admin subcommand was killed or has crashed, VNet would stop with no error message. This commit fixes that and propagates the error from osascript.
ravicious
force-pushed
the
r7s/teleterm-vnet
branch
from
1dc9fb2
to
fb0c745
Compare
ravicious
force-pushed
the
r7s/ui-dns-zones
branch
from
675136d
to
6d16204
Compare
Squashed from #41653 (only lib/vnet and tool/tsh).
It will be needed in VNet to issue app certs.
ravicious
force-pushed
the
r7s/teleterm-vnet
branch
from
fb0c745
to
a042be1
Compare
ravicious
force-pushed
the
r7s/ui-dns-zones
branch
from
6d16204
to
593f6b0
Compare
ravicious
force-pushed
the
r7s/teleterm-vnet
branch
2 times, most recently
from
c404d97
to
e3284c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the support for leaf clusters and custom DNS zones has not landed just yet, for now we show what's supported which is proxy hostnames of root clusters.
I also removed the fake connections since recent VNet connections are not going to land in v16.0.